implement more clippy suggestions

game/src/discord_rpc.rs

@@ -1,7 +1,7 @@
 use std::time::Duration;
 
 use discord_sdk::activity::ActivityBuilder;
-use tracing::{error, log::info};
+use tracing::{log::info};
 
 use crate::utilities::discord::{rpc::DiscordError, DiscordConfig, DiscordRpcClient};
 

game/src/scenes/fsm_error_screen.rs

@@ -1,8 +1,8 @@
-use std::cell::{Cell, RefCell};
+
 
 use dirty_fsm::{Action, ActionFlag};
-use raylib::{color::Color, prelude::RaylibDraw, RaylibHandle};
+use raylib::{color::Color, prelude::RaylibDraw};
-use tracing::{debug, error, info, trace};
+use tracing::{debug, trace};
 
 use crate::{
     context::GameContext,
@@ -27,14 +27,14 @@ impl Action<Scenes, ScreenError, GameContext> for FsmErrorScreen {
         Ok(())
     }
 
-    fn on_first_run(&mut self, context: &GameContext) -> Result<(), ScreenError> {
+    fn on_first_run(&mut self, _context: &GameContext) -> Result<(), ScreenError> {
         debug!("Running FsmErrorScreen for the first time");
         Ok(())
     }
 
     fn execute(
         &mut self,
-        delta: &chrono::Duration,
+        _delta: &chrono::Duration,
         context: &GameContext,
     ) -> Result<dirty_fsm::ActionFlag<Scenes>, ScreenError> {
         trace!("execute() called on FsmErrorScreen");
@@ -42,7 +42,7 @@ impl Action<Scenes, ScreenError, GameContext> for FsmErrorScreen {
         Ok(ActionFlag::Continue)
     }
 
-    fn on_finish(&mut self, interrupted: bool) -> Result<(), ScreenError> {
+    fn on_finish(&mut self, _interrupted: bool) -> Result<(), ScreenError> {
         debug!("Finished FsmErrorScreen");
         Ok(())
     }

game/src/scenes/loading_screen.rs

@@ -4,7 +4,7 @@ use dirty_fsm::{Action, ActionFlag};
 use crate::{context::GameContext, utilities::render_layer::ScreenSpaceRender};
 
 use super::{Scenes, ScreenError};
-use tracing::{debug, error, info, trace};
+use tracing::{debug, info, trace};
 
 /// Defines how long the loading screen should be displayed.
 const LOADING_SCREEN_DURATION_SECONDS: u8 = 3;
@@ -29,7 +29,7 @@ impl Action<Scenes, ScreenError, GameContext> for LoadingScreen {
         Ok(())
     }
 
-    fn on_first_run(&mut self, context: &GameContext) -> Result<(), ScreenError> {
+    fn on_first_run(&mut self, _context: &GameContext) -> Result<(), ScreenError> {
         debug!("Running LoadingScreen for the first time");
 
         // Keep track of when this screen is opened
@@ -40,7 +40,7 @@ impl Action<Scenes, ScreenError, GameContext> for LoadingScreen {
 
     fn execute(
         &mut self,
-        delta: &chrono::Duration,
+        _delta: &chrono::Duration,
         context: &GameContext,
     ) -> Result<dirty_fsm::ActionFlag<Scenes>, ScreenError> {
         trace!("execute() called on LoadingScreen");
@@ -60,7 +60,7 @@ impl Action<Scenes, ScreenError, GameContext> for LoadingScreen {
         }
     }
 
-    fn on_finish(&mut self, interrupted: bool) -> Result<(), ScreenError> {
+    fn on_finish(&mut self, _interrupted: bool) -> Result<(), ScreenError> {
         debug!("Finished LoadingScreen");
 
         // Reset the start timestamp
@@ -73,7 +73,7 @@ impl Action<Scenes, ScreenError, GameContext> for LoadingScreen {
 impl ScreenSpaceRender for LoadingScreen {
     fn render_screen_space(
         &self,
-        raylib: &mut crate::utilities::non_ref_raylib::HackedRaylibHandle,
+        _raylib: &mut crate::utilities::non_ref_raylib::HackedRaylibHandle,
     ) {
 
         // Calculate the loading screen fade in/out value

game/src/utilities/math.rs

@@ -5,10 +5,10 @@ use raylib::math::Vector2;
 
 /// Rotate a vector by an angle
 pub fn rotate_vector(vector: Vector2, angle_rad: f32) -> Vector2 {
-    return Vector2 {
+    Vector2 {
         x: (vector.x * angle_rad.cos()) - (vector.y * angle_rad.sin()),
         y: (vector.y * angle_rad.cos()) + (vector.x * angle_rad.sin()),
-    };
+    }
 }
 
 /// Interpolate a value from an input range to an output range while being modified by an exponential curve. **Input value is not checked**

game/src/utilities/non_ref_raylib.rs

@@ -1,4 +1,4 @@
-use std::{borrow::Borrow, cell::{Cell, RefCell, RefMut}, ops::{Deref, DerefMut}, rc::Rc, sync::Arc};
+use std::{ops::{Deref, DerefMut}};
 
 use raylib::{prelude::RaylibDraw, RaylibHandle};
 

game/src/utilities/shaders/shader.rs

@@ -49,7 +49,7 @@ impl ShaderWrapper {
         // Create shader
         let shader = load_shader_from_heap(
             raylib,
-            &thread,
+            thread,
             match vertex_shader_code {
                 Some(result) => match result {
                     Ok(code) => Some(code),

game/src/utilities/shaders/util/dynamic_screen_texture.rs

@@ -15,7 +15,7 @@ impl DynScreenTexture {
     pub fn new(raylib: &mut RaylibHandle, thread: &RaylibThread) -> Result<Self, String> {
         Ok(Self {
             texture: raylib.load_render_texture(
-                &thread,
+                thread,
                 raylib.get_screen_width() as u32,
                 raylib.get_screen_height() as u32,
             )?,
@@ -34,7 +34,7 @@ impl DynScreenTexture {
             || self.texture.height() != raylib.get_screen_height()
         {
             self.texture = raylib.load_render_texture(
-                &thread,
+                thread,
                 raylib.get_screen_width() as u32,
                 raylib.get_screen_height() as u32,
             )?;